-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ELY-2721] upgraded to ApacheDS AM27 and Apache Kerby KDC #2100
Conversation
@istudens FYI I just enabled CI for you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @istudens! Have added a couple small comments.
@@ -642,11 +642,6 @@ | |||
<artifactId>apacheds-kerberos-codec</artifactId> | |||
<scope>test</scope> | |||
</dependency> | |||
<dependency> | |||
<groupId>org.apache.directory.server</groupId> | |||
<artifactId>apacheds-protocol-kerberos</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be removed from the main pom.xml as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
try { | ||
kdcServer.stop(); | ||
} catch (KrbException e) { | ||
// ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to throw an IllegalStateException here to be consistent with other exceptions that are caught in this test class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@fjuma thanks for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @istudens!
Thank you for taking on this task and looking into the Kerby changes. |
Issue: https://issues.redhat.com/browse/ELY-2721